[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/23] audio: fix bit-rotted code
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH 02/23] audio: fix bit-rotted code |
|
Date: |
Thu, 14 Jan 2021 15:32:03 +0100 |
Hi,
> #ifdef DEBUG
> - alsa_dump_info(req, obt, obtfmt, pdo);
> + alsa_dump_info(req, obt, obtfmt, apdo);
> #endif
"if (DEBUG) { .... }" is a nice way to have this checked by the
compiler. With "#define DEBUG 0" the compiler will optimize away
the dead code, so it isn't much different to #ifdef'ed code.
take care,
Gerd
- [PATCH 00/23] next round of audio patches, Volker Rümelin, 2021/01/10
- [PATCH 02/23] audio: fix bit-rotted code, Volker Rümelin, 2021/01/10
- Re: [PATCH 02/23] audio: fix bit-rotted code,
Gerd Hoffmann <=
- [PATCH 01/23] sdlaudio: remove leftover SDL1.2 code, Volker Rümelin, 2021/01/10
- [PATCH 04/23] sdlaudio: don't start playback in init routine, Volker Rümelin, 2021/01/10
- [PATCH 05/23] sdlaudio: always clear the sample buffer, Volker Rümelin, 2021/01/10
- [PATCH 06/23] sdlaudio: fill remaining sample buffer with silence, Volker Rümelin, 2021/01/10