qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/23] audio: fix bit-rotted code


From: Volker Rümelin
Subject: Re: [PATCH 02/23] audio: fix bit-rotted code
Date: Sun, 31 Jan 2021 18:13:18 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

  #ifdef DEBUG
-    alsa_dump_info(req, obt, obtfmt, pdo);
+    alsa_dump_info(req, obt, obtfmt, apdo);
  #endif
"if (DEBUG) { .... }" is a nice way to have this checked by the
compiler.  With "#define DEBUG 0" the compiler will optimize away
the dead code, so it isn't much different to #ifdef'ed code.

Hi,

I will amend this in my next patch series.

With best regards,
Volker

take care,
   Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]