[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 06/11] darwin: remove redundant dependency declaration
From: |
Peter Maydell |
Subject: |
Re: [PATCH v7 06/11] darwin: remove redundant dependency declaration |
Date: |
Fri, 22 Jan 2021 22:43:39 +0000 |
On Fri, 22 Jan 2021 at 20:20, Joelle van Dyne <j@getutm.app> wrote:
>
> Meson will find CoreFoundation, IOKit, and Cocoa as needed.
>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
> ---
> configure | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configure b/configure
> index 82ce28c660..4c485dd962 100755
> --- a/configure
> +++ b/configure
> @@ -781,7 +781,6 @@ Darwin)
> fi
> audio_drv_list="coreaudio try-sdl"
> audio_possible_drivers="coreaudio sdl"
> - QEMU_LDFLAGS="-framework CoreFoundation -framework IOKit $QEMU_LDFLAGS"
> # Disable attempts to use ObjectiveC features in os/object.h since they
> # won't work when we're compiling with gcc as a C compiler.
> QEMU_CFLAGS="-DOS_OBJECT_USE_OBJC=0 $QEMU_CFLAGS"
> --
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
I notice that configure also sets
coreaudio_libs="-framework CoreAudio"
but that looks like it's something that hasn't yet been moved
into meson.build, so we can't remove it yet.
thanks
-- PMM
- [PATCH v7 00/11] iOS and Apple Silicon host support, Joelle van Dyne, 2021/01/22
- [PATCH v7 01/11] block: feature detection for host block support, Joelle van Dyne, 2021/01/22
- [PATCH v7 02/11] configure: cross-compiling with empty cross_prefix, Joelle van Dyne, 2021/01/22
- [PATCH v7 04/11] slirp: feature detection for smbd, Joelle van Dyne, 2021/01/22
- [PATCH v7 03/11] configure: check for sys/disk.h, Joelle van Dyne, 2021/01/22
- [PATCH v7 06/11] darwin: remove redundant dependency declaration, Joelle van Dyne, 2021/01/22
- Re: [PATCH v7 06/11] darwin: remove redundant dependency declaration,
Peter Maydell <=
- [PATCH v7 07/11] darwin: fix cross-compiling for Darwin, Joelle van Dyne, 2021/01/22
- [PATCH v7 08/11] configure: cross compile should use x86_64 cpu_family, Joelle van Dyne, 2021/01/22
- [PATCH v7 05/11] osdep: build with non-working system() function, Joelle van Dyne, 2021/01/22
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Peter Maydell, 2021/01/22
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Peter Maydell, 2021/01/22
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Joelle van Dyne, 2021/01/22
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Peter Maydell, 2021/01/23
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Paolo Bonzini, 2021/01/25
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Joelle van Dyne, 2021/01/25