[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 05/11] osdep: build with non-working system() function
From: |
Joelle van Dyne |
Subject: |
[PATCH v7 05/11] osdep: build with non-working system() function |
Date: |
Fri, 22 Jan 2021 12:11:07 -0800 |
Build without error on hosts without a working system(). An assertion
will trigger if system() is called.
Signed-off-by: Joelle van Dyne <j@getutm.app>
---
configure | 19 +++++++++++++++++++
include/qemu/osdep.h | 11 +++++++++++
2 files changed, 30 insertions(+)
diff --git a/configure b/configure
index 92da27846e..82ce28c660 100755
--- a/configure
+++ b/configure
@@ -5318,6 +5318,21 @@ else
sys_disk_h=no
fi
+##########################################
+# check for system()
+
+have_system_function=no
+cat > $TMPC << EOF
+#include <stdlib.h>
+int main(void) {
+ return system("");
+}
+EOF
+if compile_prog "" "" ; then
+ have_system_function=yes
+fi
+
+
##########################################
# End of CC checks
# After here, no more $cc or $ld runs
@@ -6222,6 +6237,10 @@ if test "$secret_keyring" = "yes" ; then
echo "CONFIG_SECRET_KEYRING=y" >> $config_host_mak
fi
+if test "$have_system_function" = "yes" ; then
+ echo "HAVE_SYSTEM_FUNCTION=y" >> $config_host_mak
+fi
+
echo "ROMS=$roms" >> $config_host_mak
echo "MAKE=$make" >> $config_host_mak
echo "PYTHON=$python" >> $config_host_mak
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index a434382c58..73346c4349 100644
--- a/include/qemu/osdep.h
+++ b/include/qemu/osdep.h
@@ -682,4 +682,15 @@ char *qemu_get_host_name(Error **errp);
*/
size_t qemu_get_host_physmem(void);
+/**
+ * Platforms which do not support system() gets an assertion failure.
+ */
+#ifndef HAVE_SYSTEM_FUNCTION
+#define system platform_does_not_support_system
+static inline int platform_does_not_support_system(const char *command)
+{
+ assert(0);
+}
+#endif /* !HAVE_SYSTEM_FUNCTION */
+
#endif
--
2.28.0
- [PATCH v7 04/11] slirp: feature detection for smbd, (continued)
- [PATCH v7 04/11] slirp: feature detection for smbd, Joelle van Dyne, 2021/01/22
- [PATCH v7 03/11] configure: check for sys/disk.h, Joelle van Dyne, 2021/01/22
- [PATCH v7 06/11] darwin: remove redundant dependency declaration, Joelle van Dyne, 2021/01/22
- [PATCH v7 07/11] darwin: fix cross-compiling for Darwin, Joelle van Dyne, 2021/01/22
- [PATCH v7 08/11] configure: cross compile should use x86_64 cpu_family, Joelle van Dyne, 2021/01/22
- [PATCH v7 05/11] osdep: build with non-working system() function,
Joelle van Dyne <=
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Peter Maydell, 2021/01/22
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Peter Maydell, 2021/01/22
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Joelle van Dyne, 2021/01/22
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Peter Maydell, 2021/01/23
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Paolo Bonzini, 2021/01/25
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Joelle van Dyne, 2021/01/25
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Paolo Bonzini, 2021/01/25
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Peter Maydell, 2021/01/26
[PATCH v7 09/11] block: check availablity for preadv/pwritev on mac, Joelle van Dyne, 2021/01/22
[PATCH v7 11/11] darwin: remove 64-bit build detection on 32-bit OS, Joelle van Dyne, 2021/01/22