qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 05/11] osdep: build with non-working system() function


From: Paolo Bonzini
Subject: Re: [PATCH v7 05/11] osdep: build with non-working system() function
Date: Tue, 26 Jan 2021 01:42:01 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 26/01/21 01:12, Joelle van Dyne wrote:
Here's how meson does cc.has_function

https://github.com/mesonbuild/meson/blob/master/mesonbuild/compilers/mixins/clike.py#L761

Since the compiler error comes from the header file with

__attribute__((availability(ios,unavailable)))

The meson check will always pass.

cc.compiles should work though. Is there a reason why it's not used
instead of all the compile_prog checks in ./configure ?

Just because the Meson build system is only a few months old.

Alternatively:

# If we have any includes in the prefix supplied by the user, assume # that the user wants us to use the symbol prototype defined in those
        # includes. If not, then try to do the Autoconf-style check with
        # a dummy prototype definition of our own.

so adding a "prefix: '#include <stdlib.h>'" to cc.has_function should work too.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]