[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 11/15] tests/tcg: Replace /bin/true by true (required on m
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v1 11/15] tests/tcg: Replace /bin/true by true (required on macOS) |
|
Date: |
Tue, 2 Feb 2021 15:23:07 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 2/2/21 2:39 PM, Alex Bennée wrote:
> From: Stefan Weil <sw@weilnetz.de>
>
> /bin/true is missing on macOS, but simply "true" is available as a shell
> builtin.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed ... :
https://www.mail-archive.com/qemu-devel@nongnu.org/msg777004.html
... before Peter:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg777010.html
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
His tag is and mine isn't... Is it possible this is a b4 bug when
names use UTF-8 encoding?
Again:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20210128135627.2067003-1-sw@weilnetz.de>
> ---
> tests/tcg/Makefile.qemu | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/tcg/Makefile.qemu b/tests/tcg/Makefile.qemu
> index c096c611a2..a56564660c 100644
> --- a/tests/tcg/Makefile.qemu
> +++ b/tests/tcg/Makefile.qemu
> @@ -90,11 +90,11 @@ run-guest-tests: guest-tests
>
> else
> guest-tests:
> - $(call quiet-command, /bin/true, "BUILD", \
> + $(call quiet-command, true, "BUILD", \
> "$(TARGET) guest-tests SKIPPED")
>
> run-guest-tests:
> - $(call quiet-command, /bin/true, "RUN", \
> + $(call quiet-command, true, "RUN", \
> "tests for $(TARGET) SKIPPED")
> endif
>
>
- [PATCH v1 04/15] tests/docker: preserve original name when copying libs, (continued)
- [PATCH v1 04/15] tests/docker: preserve original name when copying libs, Alex Bennée, 2021/02/02
- [PATCH v1 03/15] tests/docker: make _copy_with_mkdir accept missing files, Alex Bennée, 2021/02/02
- [PATCH v1 05/15] tests/docker: alias docker-help target for consistency, Alex Bennée, 2021/02/02
- [PATCH v1 06/15] tests/docker: add a docker-exec-copy-test, Alex Bennée, 2021/02/02
- [PATCH v1 08/15] configure: bump the minimum gdb version for check-tcg to 9.1, Alex Bennée, 2021/02/02
- [PATCH v1 09/15] tests/tcg: don't silently skip the gdb tests, Alex Bennée, 2021/02/02
- [PATCH v1 07/15] configure: make version_ge more tolerant of shady version input, Alex Bennée, 2021/02/02
- [PATCH v1 11/15] tests/tcg: Replace /bin/true by true (required on macOS), Alex Bennée, 2021/02/02
- Re: [PATCH v1 11/15] tests/tcg: Replace /bin/true by true (required on macOS),
Philippe Mathieu-Daudé <=
- [PATCH v1 12/15] scripts/mtest2make.py: export all-%s-targets variable and use it, Alex Bennée, 2021/02/02
- [PATCH v1 10/15] gdbstub: Fix handle_query_xfer_auxv, Alex Bennée, 2021/02/02
- [PATCH v1 13/15] tests/Makefile.include: don't use TARGET_DIRS for check-tcg, Alex Bennée, 2021/02/02
- [PATCH v1 15/15] docs/system: document an example booting the versatilepb machine, Alex Bennée, 2021/02/02
- [PATCH v1 14/15] docs/system: document an example vexpress-a15 invocation, Alex Bennée, 2021/02/02