[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 11/15] tests/tcg: Replace /bin/true by true (required on m
From: |
Alex Bennée |
Subject: |
Re: [PATCH v1 11/15] tests/tcg: Replace /bin/true by true (required on macOS) |
Date: |
Tue, 02 Feb 2021 18:34:58 +0000 |
User-agent: |
mu4e 1.5.7; emacs 28.0.50 |
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> On Tue, Feb 2, 2021 at 3:23 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>> On 2/2/21 2:39 PM, Alex Bennée wrote:
>> > From: Stefan Weil <sw@weilnetz.de>
>> >
>> > /bin/true is missing on macOS, but simply "true" is available as a shell
>> > builtin.
>> >
>> > Signed-off-by: Stefan Weil <sw@weilnetz.de>
>>
>> Reviewed ... :
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg777004.html
>> ... before Peter:
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg777010.html
>>
>> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>>
>> His tag is and mine isn't... Is it possible this is a b4 bug when
>> names use UTF-8 encoding?
>
> FWIW the version I'm using works:
>
> $ b4 --version
> 0.5.2
Same here... the only thing I can think of was I applied it old style
and your email hadn't been indexed yet (I have Peter's rb in my
review.org). I do generally use b4 to apply series now (as I will this
one when I roll). Sometimes however individual patches get applied
directly if I don't see anything in my email.
It would be nice if b4 could run on across an existing git tree to see
if things can be applied based on tags that may have arrived in the
interim. I think there is a potential race there while a series is
prepared.
> $ b4 am 20210128135627.2067003-1-sw@weilnetz.de
> Looking up https://lore.kernel.org/r/20210128135627.2067003-1-sw%40weilnetz.de
> Grabbing thread from lore.kernel.org/qemu-devel
> Analyzing 4 messages in the thread
> ---
> Writing ./20210128_sw_tests_tcg_replace_bin_true_by_true_required_on_macos.mbx
> [PATCH] tests/tcg: Replace /bin/true by true (required on macOS)
> + Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> + Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Total patches: 1
> ---
> Link: https://lore.kernel.org/r/20210128135627.2067003-1-sw@weilnetz.de
> Base: not found
> git am
> ./20210128_sw_tests_tcg_replace_bin_true_by_true_required_on_macos.mbx
>
>> Again:
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>
>> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> > Message-Id: <20210128135627.2067003-1-sw@weilnetz.de>
>> > ---
>> > tests/tcg/Makefile.qemu | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
--
Alex Bennée
- [PATCH v1 05/15] tests/docker: alias docker-help target for consistency, (continued)
- [PATCH v1 05/15] tests/docker: alias docker-help target for consistency, Alex Bennée, 2021/02/02
- [PATCH v1 06/15] tests/docker: add a docker-exec-copy-test, Alex Bennée, 2021/02/02
- [PATCH v1 08/15] configure: bump the minimum gdb version for check-tcg to 9.1, Alex Bennée, 2021/02/02
- [PATCH v1 09/15] tests/tcg: don't silently skip the gdb tests, Alex Bennée, 2021/02/02
- [PATCH v1 07/15] configure: make version_ge more tolerant of shady version input, Alex Bennée, 2021/02/02
- [PATCH v1 11/15] tests/tcg: Replace /bin/true by true (required on macOS), Alex Bennée, 2021/02/02
- [PATCH v1 12/15] scripts/mtest2make.py: export all-%s-targets variable and use it, Alex Bennée, 2021/02/02
- [PATCH v1 10/15] gdbstub: Fix handle_query_xfer_auxv, Alex Bennée, 2021/02/02
- [PATCH v1 13/15] tests/Makefile.include: don't use TARGET_DIRS for check-tcg, Alex Bennée, 2021/02/02
- [PATCH v1 15/15] docs/system: document an example booting the versatilepb machine, Alex Bennée, 2021/02/02
- [PATCH v1 14/15] docs/system: document an example vexpress-a15 invocation, Alex Bennée, 2021/02/02