qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/4] migration: Fix cache_init()'s "Failed to allocate" er


From: Markus Armbruster
Subject: Re: [PATCH v2 3/4] migration: Fix cache_init()'s "Failed to allocate" error messages
Date: Tue, 02 Feb 2021 16:21:23 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Eric Blake <eblake@redhat.com> writes:

> On 2/2/21 8:17 AM, Markus Armbruster wrote:
>> cache_init() attempts to handle allocation failure..  The two error
>
> The double . looks odd.

Typo.  Perhaps the maintainer can take care of it.

>> messages are garbage, as untested error messages commonly are:
>> 
>>     Parameter 'cache size' expects Failed to allocate cache
>>     Parameter 'cache size' expects Failed to allocate page cache
>> 
>> Fix them to just
>> 
>>     Failed to allocate cache
>>     Failed to allocate page cache
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> ---
>>  migration/page_cache.c | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]