[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/4] migration: Fix cache_init()'s "Failed to allocate" er
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [PATCH v2 3/4] migration: Fix cache_init()'s "Failed to allocate" error messages |
|
Date: |
Tue, 2 Feb 2021 15:37:02 +0000 |
|
User-agent: |
Mutt/1.14.6 (2020-07-11) |
* Markus Armbruster (armbru@redhat.com) wrote:
> Eric Blake <eblake@redhat.com> writes:
>
> > On 2/2/21 8:17 AM, Markus Armbruster wrote:
> >> cache_init() attempts to handle allocation failure.. The two error
> >
> > The double . looks odd.
>
> Typo. Perhaps the maintainer can take care of it.
Yeh I can try and remember to take it out on the merge.
> >> messages are garbage, as untested error messages commonly are:
> >>
> >> Parameter 'cache size' expects Failed to allocate cache
> >> Parameter 'cache size' expects Failed to allocate page cache
> >>
> >> Fix them to just
> >>
> >> Failed to allocate cache
> >> Failed to allocate page cache
> >>
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> >> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >> ---
> >> migration/page_cache.c | 6 ++----
> >> 1 file changed, 2 insertions(+), 4 deletions(-)
> >>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK