[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v15 23/23] accel-cpu: make cpu_realizefn return a bool
|
From: |
Alex Bennée |
|
Subject: |
Re: [PATCH v15 23/23] accel-cpu: make cpu_realizefn return a bool |
|
Date: |
Wed, 03 Feb 2021 16:56:32 +0000 |
|
User-agent: |
mu4e 1.5.7; emacs 28.0.50 |
Claudio Fontana <cfontana@suse.de> writes:
> overall, all devices' realize functions take an Error **errp, but return void.
>
> hw/core/qdev.c code, which realizes devices, therefore does:
>
> local_err = NULL;
> dc->realize(dev, &local_err);
> if (local_err != NULL) {
> goto fail;
> }
>
> However, we can improve at least accel_cpu to return a meaningful bool value.
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
- Re: [PATCH v15 19/23] i386: split cpu accelerators from cpu.c, using AccelCPUClass, (continued)
[PATCH v15 17/23] accel: replace struct CpusAccel with AccelOpsClass, Claudio Fontana, 2021/02/01
[PATCH v15 23/23] accel-cpu: make cpu_realizefn return a bool, Claudio Fontana, 2021/02/01
Re: [PATCH v15 00/23] i386 cleanup PART 2, Alex Bennée, 2021/02/03
Re: [PATCH v15 00/23] i386 cleanup PART 2, Alex Bennée, 2021/02/03