[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v15 00/23] i386 cleanup PART 2
From: |
Claudio Fontana |
Subject: |
Re: [PATCH v15 00/23] i386 cleanup PART 2 |
Date: |
Wed, 3 Feb 2021 18:10:57 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
Hi Alex,
thanks for your review,
On 2/3/21 5:57 PM, Alex Bennée wrote:
>
> Claudio Fontana <cfontana@suse.de> writes:
>
> <snip>
>
> Final comments. I think overall this series is looking pretty good
> although I got a bit lost at the end when we started expanding on the
> AccelClass.
> The main yuck was the start-up ordering constraint which
To be sure, are you referring to tcg_accel_ops_init(), ie your comments towards
the end of PATCH 17?
Ciao,
Claudio
> would be nice to remove or failing that catch with some asserts so weird
> bugs don't get introduced.
>
> Paolo, is it worth picking up some of the early patches to reduce the
> patch delta going forward?
>
- [PATCH v15 17/23] accel: replace struct CpusAccel with AccelOpsClass, (continued)