[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 07/18] migration/rdma: add rdma field into multifd send/re
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH v4 07/18] migration/rdma: add rdma field into multifd send/recv param |
Date: |
Wed, 3 Feb 2021 18:32:34 +0000 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
* Chuan Zheng (zhengchuan@huawei.com) wrote:
> Note we do want to export any rdma struct, take void * instead.
You don't need to make this a void *; add a typedef struct RDMAContext
into include/qemu/typedefs.h and then you can use the right type here
without actually exporting the interesting contents of the type or
being dependent on rdma being built.
Dave
> Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
> ---
> migration/multifd.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/migration/multifd.h b/migration/multifd.h
> index d57756c..b17a2c1 100644
> --- a/migration/multifd.h
> +++ b/migration/multifd.h
> @@ -108,6 +108,10 @@ typedef struct {
> QemuSemaphore sem_sync;
> /* used for compression methods */
> void *data;
> + /* used for multifd rdma */
> + void *rdma;
> + /* communication channel */
> + QEMUFile *file;
> } MultiFDSendParams;
>
> typedef struct {
> @@ -147,6 +151,10 @@ typedef struct {
> QemuSemaphore sem_sync;
> /* used for de-compression methods */
> void *data;
> + /* used for multifd rdma */
> + void *rdma;
> + /* communication channel */
> + QEMUFile *file;
> } MultiFDRecvParams;
>
> typedef struct {
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- [PATCH v4 01/18] migration/rdma: add the 'migrate_rdma_pin_all' function, (continued)
- [PATCH v4 01/18] migration/rdma: add the 'migrate_rdma_pin_all' function, Chuan Zheng, 2021/02/03
- [PATCH v4 05/18] migration/rdma: do not need sync main for rdma, Chuan Zheng, 2021/02/03
- [PATCH v4 12/18] migration/rdma: Create the multifd send channels for RDMA, Chuan Zheng, 2021/02/03
- [PATCH v4 13/18] migration/rdma: Add the function for dynamic page registration, Chuan Zheng, 2021/02/03
- [PATCH v4 11/18] migration/rdma: record host_port for multifd RDMA, Chuan Zheng, 2021/02/03
- [PATCH v4 07/18] migration/rdma: add rdma field into multifd send/recv param, Chuan Zheng, 2021/02/03
- Re: [PATCH v4 07/18] migration/rdma: add rdma field into multifd send/recv param,
Dr. David Alan Gilbert <=
- [PATCH v4 02/18] migration/rdma: judge whether or not the RDMA is used for migration, Chuan Zheng, 2021/02/03
- [PATCH v4 03/18] migration/rdma: create multifd_setup_ops for Tx/Rx thread, Chuan Zheng, 2021/02/03
- [PATCH v4 15/18] migration/rdma: only register the memory for multifd channels, Chuan Zheng, 2021/02/03
- [PATCH v4 06/18] migration/rdma: export MultiFDSendParams/MultiFDRecvParams, Chuan Zheng, 2021/02/03
- [PATCH v4 14/18] migration/rdma: register memory for multifd RDMA channels, Chuan Zheng, 2021/02/03
- [PATCH v4 08/18] migration/rdma: export getQIOChannel to get QIOchannel in rdma, Chuan Zheng, 2021/02/03