[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/22] tests/acceptance/boot_linux.py: rename misleading clou
|
From: |
Alex Bennée |
|
Subject: |
Re: [PATCH 02/22] tests/acceptance/boot_linux.py: rename misleading cloudinit method |
|
Date: |
Thu, 04 Feb 2021 10:47:31 +0000 |
|
User-agent: |
mu4e 1.5.7; emacs 28.0.50 |
Cleber Rosa <crosa@redhat.com> writes:
> There's no downloading happening on that method, so let's call it
> "prepare" instead. While at it, and because of it, the current
> "prepare_boot" and "prepare_cloudinit" are also renamed.
>
> The reasoning here is that "prepare_" methods will just work on the
> images, while "set_up_" will make them effective to the VM that will
> be launched. Inspiration comes from the "virtiofs_submounts.py"
> tests, which this expects to converge more into.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
- [PATCH 00/22] Acceptance Test: introduce base class for Linux based tests, Cleber Rosa, 2021/02/03
- [PATCH 02/22] tests/acceptance/boot_linux.py: rename misleading cloudinit method, Cleber Rosa, 2021/02/03
- [PATCH 05/22] tests/acceptance/virtiofs_submounts.py: do not ask for ssh key password, Cleber Rosa, 2021/02/03
- [PATCH 03/22] Acceptance Tests: remove unnecessary tag from documentation example, Cleber Rosa, 2021/02/03
- [PATCH 09/22] tests/acceptance/virtiofs_submounts.py: required space between IP and port, Cleber Rosa, 2021/02/03
- [PATCH 10/22] Python: add utility function for retrieving port redirection, Cleber Rosa, 2021/02/03