[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/22] tests/acceptance/virtiofs_submounts.py: do not ask for
From: |
Beraldo Leal |
Subject: |
Re: [PATCH 05/22] tests/acceptance/virtiofs_submounts.py: do not ask for ssh key password |
Date: |
Thu, 4 Feb 2021 08:05:37 -0300 |
On Wed, Feb 03, 2021 at 12:23:40PM -0500, Cleber Rosa wrote:
> Tests are supposed to be non-interactive, and ssh-keygen is asking for
> a password when creating a key. Let's set an empty key, which prevents
> ssh-keygen for asking for a password.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> tests/acceptance/virtiofs_submounts.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/acceptance/virtiofs_submounts.py
> b/tests/acceptance/virtiofs_submounts.py
> index 68d3cd6869..3b5a242385 100644
> --- a/tests/acceptance/virtiofs_submounts.py
> +++ b/tests/acceptance/virtiofs_submounts.py
> @@ -235,7 +235,7 @@ class VirtiofsSubmountsTest(BootLinux):
>
> self.ssh_key = os.path.join(self.workdir, 'id_ed25519')
>
> - self.run(('ssh-keygen', '-t', 'ed25519', '-f', self.ssh_key))
> + self.run(('ssh-keygen', '-N', '', '-t', 'ed25519', '-f',
> self.ssh_key))
>
> pubkey = open(self.ssh_key + '.pub').read()
>
> --
> 2.25.4
>
Reviewed-by: Beraldo Leal <bleal@redhat.com>
- [PATCH 00/22] Acceptance Test: introduce base class for Linux based tests, Cleber Rosa, 2021/02/03
- [PATCH 02/22] tests/acceptance/boot_linux.py: rename misleading cloudinit method, Cleber Rosa, 2021/02/03
- [PATCH 05/22] tests/acceptance/virtiofs_submounts.py: do not ask for ssh key password, Cleber Rosa, 2021/02/03
- [PATCH 03/22] Acceptance Tests: remove unnecessary tag from documentation example, Cleber Rosa, 2021/02/03
- [PATCH 09/22] tests/acceptance/virtiofs_submounts.py: required space between IP and port, Cleber Rosa, 2021/02/03
- [PATCH 10/22] Python: add utility function for retrieving port redirection, Cleber Rosa, 2021/02/03