[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/9] monitor/qmp-cmds.c: Don't include ui/vnc.h
From: |
Markus Armbruster |
Subject: |
[PULL 1/9] monitor/qmp-cmds.c: Don't include ui/vnc.h |
Date: |
Thu, 4 Feb 2021 15:01:28 +0100 |
From: Peter Maydell <peter.maydell@linaro.org>
The qmp-cmds.c file currently includes ui/vnc.h, which (being located
in the ui/ directory rather than include) is really supposed to be
for use only by the ui subsystem. In fact the function prototypes we
need (vnc_display_password(), etc) are all declared in
include/ui/console.h, so we can switch to including that instead.
(ui/vnc.h includes include/ui/console.h, so this change strictly
reduces the quantity of headers qmp-cmds.c pulls in.)
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20210104161200.15068-1-peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
monitor/qmp-cmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor/qmp-cmds.c b/monitor/qmp-cmds.c
index 990936136c..c7df8c0ee2 100644
--- a/monitor/qmp-cmds.c
+++ b/monitor/qmp-cmds.c
@@ -23,7 +23,7 @@
#include "qemu/uuid.h"
#include "chardev/char.h"
#include "ui/qemu-spice.h"
-#include "ui/vnc.h"
+#include "ui/console.h"
#include "sysemu/kvm.h"
#include "sysemu/runstate.h"
#include "sysemu/runstate-action.h"
--
2.26.2
- [PULL 0/9] QMP patches patches for 2021-02-04, Markus Armbruster, 2021/02/04
- [PULL 4/9] qobject: spaces required around that operators, Markus Armbruster, 2021/02/04
- [PULL 8/9] qmp: Add more tracepoints, Markus Armbruster, 2021/02/04
- [PULL 3/9] qobject: code indent should never use tabs, Markus Armbruster, 2021/02/04
- [PULL 5/9] qobject: braces {} are necessary for all arms of this statement, Markus Armbruster, 2021/02/04
- [PULL 2/9] qobject: open brace '{' following struct go on the same line, Markus Armbruster, 2021/02/04
- [PULL 7/9] qmp: Fix up comments after commit 9ce44e2ce2, Markus Armbruster, 2021/02/04
- [PULL 1/9] monitor/qmp-cmds.c: Don't include ui/vnc.h,
Markus Armbruster <=
- [PULL 6/9] docs/interop/qmp-spec: Document the request queue limit, Markus Armbruster, 2021/02/04
- [PULL 9/9] qmp: Resume OOB-enabled monitor before processing the request, Markus Armbruster, 2021/02/04
- Re: [PULL 0/9] QMP patches patches for 2021-02-04, no-reply, 2021/02/04
- Re: [PULL 0/9] QMP patches patches for 2021-02-04, Peter Maydell, 2021/02/04