Re: [PULL 0/9] QMP patches patches for 2021-02-04

[no-reply]

Patchew URL: 
20210204140136.2769065-1-armbru@redhat.com/">https://patchew.org/QEMU/20210204140136.2769065-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210204140136.2769065-1-armbru@redhat.com
Subject: [PULL 0/9] QMP patches patches for 2021-02-04

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210128003223.3561108-1-f4bug@amsat.org -> 
patchew/20210128003223.3561108-1-f4bug@amsat.org
 * [new tag]         patchew/20210204140136.2769065-1-armbru@redhat.com -> 
patchew/20210204140136.2769065-1-armbru@redhat.com
Switched to a new branch 'test'
6db5e4e qmp: Resume OOB-enabled monitor before processing the request
6a67c5fb qmp: Add more tracepoints
4661e67 qmp: Fix up comments after commit 9ce44e2ce2
764b192 docs/interop/qmp-spec: Document the request queue limit
57fcaf0 qobject: braces {} are necessary for all arms of this statement
e8ad6c0 qobject: spaces required around that operators
d083c84 qobject: code indent should never use tabs
2d7dc45 qobject: open brace '{' following struct go on the same line
b107051 monitor/qmp-cmds.c: Don't include ui/vnc.h

=== OUTPUT BEGIN ===
1/9 Checking commit b107051cffb4 (monitor/qmp-cmds.c: Don't include ui/vnc.h)
2/9 Checking commit 2d7dc454821b (qobject: open brace '{' following struct go 
on the same line)
3/9 Checking commit d083c8413d95 (qobject: code indent should never use tabs)
4/9 Checking commit e8ad6c0fb2b7 (qobject: spaces required around that 
operators)
ERROR: braces {} are necessary for all arms of this statement
#28: FILE: qobject/qdict.c:46:
+    for (value = 0x238F13AF * strlen(name), i = 0; name[i]; i++)
[...]

total: 1 errors, 0 warnings, 10 lines checked

Patch 4/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/9 Checking commit 57fcaf03568f (qobject: braces {} are necessary for all arms 
of this statement)
6/9 Checking commit 764b1924d5b4 (docs/interop/qmp-spec: Document the request 
queue limit)
7/9 Checking commit 4661e67c592f (qmp: Fix up comments after commit 9ce44e2ce2)
8/9 Checking commit 6a67c5fb8c1a (qmp: Add more tracepoints)
9/9 Checking commit 6db5e4ef9c3d (qmp: Resume OOB-enabled monitor before 
processing the request)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210204140136.2769065-1-armbru@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210204140136.2769065-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com