[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] hw/block/nvme: add support for telemetry log pages
|
From: |
Keith Busch |
|
Subject: |
Re: [PATCH 0/2] hw/block/nvme: add support for telemetry log pages |
|
Date: |
Tue, 9 Feb 2021 00:40:08 +0900 |
|
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Mon, Feb 08, 2021 at 03:10:10PM +0100, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> This adds support for the telemetry log pages and fixes up the
> controller IEEE OUI.
Patch 1 is fine.
I don't see the point for patch 2. We don't need an empty implementation
for every optional spec feature just because it's there. The features
we do implement ought to provide something useful, yeah?