[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] hw/block/nvme: add support for telemetry log pages
|
From: |
Klaus Jensen |
|
Subject: |
Re: [PATCH 0/2] hw/block/nvme: add support for telemetry log pages |
|
Date: |
Mon, 8 Feb 2021 18:47:01 +0100 |
On Feb 9 00:40, Keith Busch wrote:
> On Mon, Feb 08, 2021 at 03:10:10PM +0100, Klaus Jensen wrote:
> > From: Klaus Jensen <k.jensen@samsung.com>
> >
> > This adds support for the telemetry log pages and fixes up the
> > controller IEEE OUI.
>
> Patch 1 is fine.
>
> I don't see the point for patch 2. We don't need an empty implementation
> for every optional spec feature just because it's there. The features
> we do implement ought to provide something useful, yeah?
Alright, point taken :)
signature.asc
Description: PGP signature