[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 16/21] hw/timer: Refactor NPCM7XX Timer to use CLK clock
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PULL 16/21] hw/timer: Refactor NPCM7XX Timer to use CLK clock |
Date: |
Wed, 10 Feb 2021 12:54:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 2/4/21 11:37 PM, Hao Wu wrote:
> I don't see this error. It could be some error in the clock that the
> timer module does not get a correct clock input.
> How do you reproduce this?
I got it only once, can not reproduce, but it happened on our CI too:
https://gitlab.com/qemu-project/qemu/-/jobs/1006073367#L4430
>
> On Thu, Feb 4, 2021 at 1:39 AM Philippe Mathieu-Daudé <f4bug@amsat.org
> <mailto:f4bug@amsat.org>> wrote:
>
> Hi,
>
> On Tue, Jan 12, 2021 at 6:20 PM Peter Maydell
> <peter.maydell@linaro.org <mailto:peter.maydell@linaro.org>>
> wrote:
> >
> > From: Hao Wu <wuhaotsh@google.com <mailto:wuhaotsh@google.com>>
> >
> > This patch makes NPCM7XX Timer to use a the timer clock generated
> by the
> > CLK module instead of the magic number TIMER_REF_HZ.
> >
> > Reviewed-by: Havard Skinnemoen <hskinnemoen@google.com
> <mailto:hskinnemoen@google.com>>
> > Reviewed-by: Tyrone Ting <kfting@nuvoton.com
> <mailto:kfting@nuvoton.com>>
> > Signed-off-by: Hao Wu <wuhaotsh@google.com
> <mailto:wuhaotsh@google.com>>
> > Message-id: 20210108190945.949196-3-wuhaotsh@google.com
> <mailto:20210108190945.949196-3-wuhaotsh@google.com>
> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org
> <mailto:peter.maydell@linaro.org>>
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org
> <mailto:peter.maydell@linaro.org>>
> > ---
> > include/hw/misc/npcm7xx_clk.h | 6 -----
> > include/hw/timer/npcm7xx_timer.h | 1 +
> > hw/arm/npcm7xx.c | 5 ++++
> > hw/timer/npcm7xx_timer.c | 39
> +++++++++++++++-----------------
> > 4 files changed, 24 insertions(+), 27 deletions(-)
>
> Is that a spurious error (building with Clang)?
>
> Running test qtest-arm/npcm7xx_timer-test
> ERROR:../tests/qtest/npcm7xx_timer-test.c:475:test_periodic_interrupt:
> assertion failed (tim_read(td, TISR) == tim_timer_bit(td)): (0x00000000
> == 0x00000004)
> ERROR:../tests/qtest/npcm7xx_timer-test.c:476:test_periodic_interrupt:
> 'qtest_get_irq(global_qtest, tim_timer_irq(td))' should be TRUE
> FAIL 155 qtest-arm/npcm7xx_timer-test
> /arm/npcm7xx_timer/tim[2]/timer[2]/periodic_interrupt
> make: *** [Makefile.mtest:1033: run-test-127] Error 1
>