[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qom/object.c: Fix typo
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] qom/object.c: Fix typo |
Date: |
Fri, 12 Feb 2021 10:38:25 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
Hi Doug,
On 2/12/21 1:56 AM, Doug Evans via wrote:
> A simple typo (noticed by inspection).
>
> commit ccdffd2c10c5e4447d5e462a6ad2f351df502dee
> Author: Doug Evans <dje@google.com>
> Date: Thu Feb 11 16:29:13 2021 -0800
>
> qom/object.c: Fix typo
>
> Signed-off-by: Doug Evans <dje@google.com>
Your patch can be applied with git-am, but with author
Doug Evans via <qemu-devel@nongnu.org> and contains an invalid
commit reference.
Can you use git-format-patch which inserts a From: tag so your
email is properly set and you don't have to worry with the issues
with your email provider:
https://wiki.qemu.org/Contribute/SubmitAPatch#Use_git_format-patch
> diff --git a/qom/object.c b/qom/object.c
> index 491823db4a..6a01d56546 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -695,7 +695,7 @@ static void object_finalize(void *data)
>
> /* Find the minimum alignment guaranteed by the system malloc. */
> #if __STDC_VERSION__ >= 201112L
> -typddef max_align_t qemu_max_align_t;
> +typedef max_align_t qemu_max_align_t;
> #else
> typedef union {
> long l;
>
For the typo:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>