Re: RFC Qemu mipssim patches

[Philippe Mathieu-Daudé]

On 2/12/21 1:13 AM, Philippe Mathieu-Daudé wrote:
> Hi Reinoud,
> 
> On 2/11/21 4:37 PM, Reinoud Zandijk wrote:
>> Hi,
>>
>> i'd like to get the following simple patches to the MIPS/mipssim target 
>> adding
>> virtio-mmio devices to it.

Please submit your patches as a series so we can review them on
the list:
https://wiki.qemu.org/Contribute/SubmitAPatch#Use_git_format-patch

BTW you are ORing the IRQ pointer, so you are likely loosing
interrupts...

In case you want to keep using the MIPSsim, see this example
commit on how to use an OR gate:
https://gitlab.com/qemu-project/qemu/-/commit/a879306ca14

>> This makes the target a lot more usefull as microvm
>> for kernel developement. It currently lives in our qemu extensions patches 
>> and
>> we have a working kernel that supports all virtio devices for it.
>>
>> Thoughts?
> 
> Why not start a cleanly specified machine, as Laurent is doing on m68k?
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg768802.html
> 
> This one doesn't even have an interrupt controller.
> 
> Cc'ing Aleksandar who maintains this machine.
> 
> Regards,
> 
> Phil.
>