[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 09/24] python: add pylint import exceptions
|
From: |
Cleber Rosa |
|
Subject: |
Re: [PATCH v4 09/24] python: add pylint import exceptions |
|
Date: |
Tue, 16 Feb 2021 22:07:28 -0500 |
On Thu, Feb 11, 2021 at 01:58:41PM -0500, John Snow wrote:
> Pylint 2.5.x and 2.6.x have regressions that make import checking
> inconsistent, see:
>
> https://github.com/PyCQA/pylint/issues/3609
> https://github.com/PyCQA/pylint/issues/3624
> https://github.com/PyCQA/pylint/issues/3651
>
> Pinning to 2.4.4 is worse, because it mandates versions of shared
> dependencies that are too old for features we want in isort and mypy.
> Oh well.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/machine/__init__.py | 3 +++
> python/qemu/machine/machine.py | 2 +-
> python/qemu/machine/qtest.py | 2 +-
> 3 files changed, 5 insertions(+), 2 deletions(-)
>
I can see your struggle on those issues, so I choose not to punish
myself attempting to replicate them. I'll forever trust you in these
matters.
Reviewed-by: Cleber Rosa <crosa@redhat.com>
signature.asc
Description: PGP signature
[PATCH v4 06/24] python: add VERSION file, John Snow, 2021/02/11
[PATCH v4 17/24] python/qemu: add isort to pipenv, John Snow, 2021/02/11
[PATCH v4 09/24] python: add pylint import exceptions, John Snow, 2021/02/11
- Re: [PATCH v4 09/24] python: add pylint import exceptions,
Cleber Rosa <=
[PATCH v4 14/24] python: move mypy.ini into setup.cfg, John Snow, 2021/02/11
[PATCH v4 10/24] python: move pylintrc into setup.cfg, John Snow, 2021/02/11
[PATCH v4 11/24] python: add pylint to pipenv, John Snow, 2021/02/11
[PATCH v4 07/24] python: add directory structure README.rst files, John Snow, 2021/02/11
[PATCH v4 12/24] python: move flake8 config to setup.cfg, John Snow, 2021/02/11