Re: [PATCH v4 09/24] python: add pylint import exceptions

[John Snow]

On 2/16/21 10:07 PM, Cleber Rosa wrote:
> On Thu, Feb 11, 2021 at 01:58:41PM -0500, John Snow wrote:
> > Pylint 2.5.x and 2.6.x have regressions that make import checking
> > inconsistent, see:
> >
> > https://github.com/PyCQA/pylint/issues/3609
> > https://github.com/PyCQA/pylint/issues/3624
> > https://github.com/PyCQA/pylint/issues/3651
> >
> > Pinning to 2.4.4 is worse, because it mandates versions of shared
> > dependencies that are too old for features we want in isort and mypy.
> > Oh well.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >   python/qemu/machine/__init__.py | 3 +++
> >   python/qemu/machine/machine.py  | 2 +-
> >   python/qemu/machine/qtest.py    | 2 +-
> >   3 files changed, 5 insertions(+), 2 deletions(-)
>
> I can see your struggle on those issues, so I choose not to punish
> myself attempting to replicate them.  I'll forever trust you in these
> matters.

:~)

> Reviewed-by: Cleber Rosa <crosa@redhat.com>

Thanks!