Re: [PATCH v2] Correct CRIS TCG register lifetime management

[Stefan Sandström]

> On 18 Feb 2021, at 20:59, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> 
> Hi Stefan,
> 
>> On 2/18/21 7:43 PM, Stefan Sandström wrote:
>> From: Stefan Sandstrom <stefans@axis.com>
>> 
>> Add and fix deallocation of temporary TCG registers in CRIS code
>> generation.
> 
> What did you run to figure this out?

Hi Philippe,

We were looking at the code in search for an issue that showed up when 
switching to a new version of GCC. 
It looked like QEMU executed the CRIS code wrong, so we took a look at the 
code. The problem turned out to be outside QEMU. These potential issues were 
spotted in the process.

> 
>> Change-Id: I17fce5d95bdc4418337ba885d53ba97afb1bafcc
>> Signed-off-by: Stefan Sandstrom <stefans@axis.com>
>> ---
>> target/cris/translate.c         | 132 
>> ++++++++++++++++++++++++++++------------
>> target/cris/translate_v10.c.inc |  70 ++++++++++++++-------
>> 2 files changed, 141 insertions(+), 61 deletions(-)