Re: [PATCH v2] Correct CRIS TCG register lifetime management

[Stefan Sandström]

> On 18 Feb 2021, at 21:26, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> 
> On 2/18/21 9:10 PM, Stefan Sandström wrote:
>>> On 18 Feb 2021, at 20:59, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>> 
>>> Hi Stefan,
>>> 
>>>> On 2/18/21 7:43 PM, Stefan Sandström wrote:
>>>> From: Stefan Sandstrom <stefans@axis.com>
>>>> 
>>>> Add and fix deallocation of temporary TCG registers in CRIS code
>>>> generation.
>>> 
>>> What did you run to figure this out?
>> 
>> Hi Philippe,
>> 
>> We were looking at the code in search for an issue that showed up when 
>> switching to a new version of GCC. 
>> It looked like QEMU executed the CRIS code wrong, so we took a look at the 
>> code. The problem turned out to be outside QEMU. These potential issues were 
>> spotted in the process.
> 
> Good to know. Do you mind sharing your GCC tests, so we can have more
> CRIS testing?

Unfortunately, we do not have such tests.
But if we end up writing such tests, we'll be happy to share them.

In this case, tt was the GCC used for building QEMU that was upgraded,
and some production firmware that was tested in QEMU that stopped working.

Best regards,
-stefan

> 
> Regards,
> 
> Phil.