[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 11/14] qmp: Include "share" property of memory backends
From: |
David Hildenbrand |
Subject: |
[PATCH v5 11/14] qmp: Include "share" property of memory backends |
Date: |
Tue, 13 Apr 2021 11:14:18 +0200 |
Let's include the property, which can be helpful when debugging,
for example, to spot misuse of MAP_PRIVATE which can result in some ugly
corner cases (e.g., double-memory consumption on shmem).
Use the same description we also use for describing the property.
Cc: Eric Blake <eblake@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/core/machine-qmp-cmds.c | 1 +
qapi/machine.json | 3 +++
2 files changed, 4 insertions(+)
diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c
index 68a942595a..d41db5b93b 100644
--- a/hw/core/machine-qmp-cmds.c
+++ b/hw/core/machine-qmp-cmds.c
@@ -174,6 +174,7 @@ static int query_memdev(Object *obj, void *opaque)
m->merge = object_property_get_bool(obj, "merge", &error_abort);
m->dump = object_property_get_bool(obj, "dump", &error_abort);
m->prealloc = object_property_get_bool(obj, "prealloc", &error_abort);
+ m->share = object_property_get_bool(obj, "share", &error_abort);
m->policy = object_property_get_enum(obj, "policy", "HostMemPolicy",
&error_abort);
host_nodes = object_property_get_qobject(obj,
diff --git a/qapi/machine.json b/qapi/machine.json
index 758b901185..32650bfe9e 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -796,6 +796,8 @@
#
# @prealloc: whether memory was preallocated
#
+# @share: whether memory is private to QEMU or shared (since 6.1)
+#
# @host-nodes: host nodes for its memory policy
#
# @policy: memory policy of memory backend
@@ -809,6 +811,7 @@
'merge': 'bool',
'dump': 'bool',
'prealloc': 'bool',
+ 'share': 'bool',
'host-nodes': ['uint16'],
'policy': 'HostMemPolicy' }}
--
2.30.2
- Re: [PATCH v5 05/14] softmmu/memory: Pass ram_flags to memory_region_init_ram_shared_nomigrate(), (continued)
[PATCH v5 07/14] memory: Introduce RAM_NORESERVE and wire it up in qemu_ram_mmap(), David Hildenbrand, 2021/04/13
[PATCH v5 06/14] util/mmap-alloc: Pass flags instead of separate bools to qemu_ram_mmap(), David Hildenbrand, 2021/04/13
[PATCH v5 08/14] util/mmap-alloc: Support RAM_NORESERVE via MAP_NORESERVE under Linux, David Hildenbrand, 2021/04/13
[PATCH v5 09/14] hostmem: Wire up RAM_NORESERVE via "reserve" property, David Hildenbrand, 2021/04/13
[PATCH v5 10/14] qmp: Clarify memory backend properties returned via query-memdev, David Hildenbrand, 2021/04/13
[PATCH v5 11/14] qmp: Include "share" property of memory backends,
David Hildenbrand <=
[PATCH v5 13/14] qmp: Include "reserve" property of memory backends, David Hildenbrand, 2021/04/13
[PATCH v5 14/14] hmp: Print "reserve" property of memory backends with "info memdev", David Hildenbrand, 2021/04/13
[PATCH v5 12/14] hmp: Print "share" property of memory backends with "info memdev", David Hildenbrand, 2021/04/13