[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 11/14] qmp: Include "share" property of memory backends
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v5 11/14] qmp: Include "share" property of memory backends |
Date: |
Tue, 20 Apr 2021 12:28:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/13/21 11:14 AM, David Hildenbrand wrote:
> Let's include the property, which can be helpful when debugging,
> for example, to spot misuse of MAP_PRIVATE which can result in some ugly
> corner cases (e.g., double-memory consumption on shmem).
>
> Use the same description we also use for describing the property.
>
> Cc: Eric Blake <eblake@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> hw/core/machine-qmp-cmds.c | 1 +
> qapi/machine.json | 3 +++
> 2 files changed, 4 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- Re: [PATCH v5 05/14] softmmu/memory: Pass ram_flags to memory_region_init_ram_shared_nomigrate(), (continued)
[PATCH v5 07/14] memory: Introduce RAM_NORESERVE and wire it up in qemu_ram_mmap(), David Hildenbrand, 2021/04/13
[PATCH v5 06/14] util/mmap-alloc: Pass flags instead of separate bools to qemu_ram_mmap(), David Hildenbrand, 2021/04/13
[PATCH v5 08/14] util/mmap-alloc: Support RAM_NORESERVE via MAP_NORESERVE under Linux, David Hildenbrand, 2021/04/13
[PATCH v5 09/14] hostmem: Wire up RAM_NORESERVE via "reserve" property, David Hildenbrand, 2021/04/13
[PATCH v5 10/14] qmp: Clarify memory backend properties returned via query-memdev, David Hildenbrand, 2021/04/13
[PATCH v5 11/14] qmp: Include "share" property of memory backends, David Hildenbrand, 2021/04/13
- Re: [PATCH v5 11/14] qmp: Include "share" property of memory backends,
Philippe Mathieu-Daudé <=
[PATCH v5 13/14] qmp: Include "reserve" property of memory backends, David Hildenbrand, 2021/04/13
[PATCH v5 14/14] hmp: Print "reserve" property of memory backends with "info memdev", David Hildenbrand, 2021/04/13
[PATCH v5 12/14] hmp: Print "share" property of memory backends with "info memdev", David Hildenbrand, 2021/04/13