Re: [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property

[David Hildenbrand]

> > diff --git a/backends/hostmem.c b/backends/hostmem.c
> > index c6c1ff5b99..58fdc1b658 100644
> > --- a/backends/hostmem.c
> > +++ b/backends/hostmem.c
> > @@ -217,6 +217,11 @@ static void host_memory_backend_set_prealloc(Object *obj, 
> > bool value,
> >       Error *local_err = NULL;
> >       HostMemoryBackend *backend = MEMORY_BACKEND(obj);
> >   
> > +    if (!backend->reserve && value) {
> > +        error_setg(errp, "'prealloc=on' and 'reserve=off' are incompatible");
> > +        return;
> > +    }
>
> Aha.  Shouldn't this be documented in qom.json?

Whoops, skipped that comment. Can add it if that's the place to document 
that.

--
Thanks,

David / dhildenb