[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" proper
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property |
|
Date: |
Fri, 23 Apr 2021 14:10:04 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
David Hildenbrand <david@redhat.com> writes:
>>> diff --git a/backends/hostmem.c b/backends/hostmem.c
>>> index c6c1ff5b99..58fdc1b658 100644
>>> --- a/backends/hostmem.c
>>> +++ b/backends/hostmem.c
>>> @@ -217,6 +217,11 @@ static void host_memory_backend_set_prealloc(Object
>>> *obj, bool value,
>>> Error *local_err = NULL;
>>> HostMemoryBackend *backend = MEMORY_BACKEND(obj);
>>> + if (!backend->reserve && value) {
>>> + error_setg(errp, "'prealloc=on' and 'reserve=off' are
>>> incompatible");
>>> + return;
>>> + }
>>
>> Aha. Shouldn't this be documented in qom.json?
>
> Whoops, skipped that comment. Can add it if that's the place to
> document that.
Yes, please. .json doc comments is where we document the external
interface.
- [PATCH v6 06/15] softmmu/memory: Pass ram_flags to qemu_ram_alloc() and qemu_ram_alloc_internal(), (continued)
[PATCH v6 08/15] memory: Introduce RAM_NORESERVE and wire it up in qemu_ram_mmap(), David Hildenbrand, 2021/04/21
[PATCH v6 11/15] qmp: Clarify memory backend properties returned via query-memdev, David Hildenbrand, 2021/04/21
[PATCH v6 12/15] qmp: Include "share" property of memory backends, David Hildenbrand, 2021/04/21
[PATCH v6 13/15] hmp: Print "share" property of memory backends with "info memdev", David Hildenbrand, 2021/04/21