[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] gitlab-ci: Add a job to build virtiofsd standalone
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 2/2] gitlab-ci: Add a job to build virtiofsd standalone |
Date: |
Thu, 29 Apr 2021 11:41:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/29/21 10:43 AM, Daniel P. Berrangé wrote:
> On Thu, Apr 29, 2021 at 10:33:46AM +0200, Philippe Mathieu-Daudé wrote:
>> Add a job which builds virtiofsd without any emulation or tool.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> https://gitlab.com/philmd/qemu/-/jobs/1222007991
>> Duration: 7 minutes 48 seconds
>> ---
>> .gitlab-ci.yml | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index 52d65d6c04f..ba3c7ade6ca 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -800,6 +800,19 @@ build-libvhost-user:
>> - meson
>> - ninja
>>
>> +build-virtiofsd-fedora:
>> + <<: *native_build_job_definition
>> + needs:
>> + job: amd64-fedora-container
>> + variables:
>> + IMAGE: fedora
>> + CONFIGURE_ARGS: --enable-virtiofsd
>> + --disable-system --disable-user --disable-tools --disable-docs
>> + artifacts:
>> + expire_in: 2 days
>> + paths:
>> + - build/tools/virtiofsd/virtiofsd
>
> I'm not convinced that this job is justiable given our need to keep
> the total CI pipeline size constrained. The precedent this sets is
> that we need to test every configure args combination for each binary
> we build. That is not scalable as a pattern. Neither this virtiofsd
> arg scenario, nor others is going to be commonly used by downstream
> consumers of QEMU, so the payoff from having this job is also small.
I'm not sure "our current pipelines is too busy because we don't have
a clear idea what is tested and what is duplicated" justifies no more
tests can be added, but it is a effective way to have the current set
cleaned.
Anyhow, if mainstream isn't interested by this configuration, it could
be added to the virtio-fs/qemu fork. Alternatively mainstream with:
only:
variables:
- $CI_PROJECT_NAMESPACE == 'virtio-fs'