Re: [PATCH v2 1/2] meson: Select 'have_system' when virtiofsd is enabled

[Dr. David Alan Gilbert]

* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> On 4/29/21 3:50 PM, Connor Kuehl wrote:
> > On 4/29/21 3:33 AM, Philippe Mathieu-Daudé wrote:
> >> When not explicitly select a sysemu target and building virtiofsd,
> >> the seccomp/cap-ng libraries are not resolved, leading to this error:
> >>
> >>   $ configure --target-list=i386-linux-user --disable-tools 
> >> --enable-virtiofsd
> >>   tools/meson.build:12:6: ERROR: Problem encountered: virtiofsd requires 
> >> libcap-ng-devel and seccomp-devel
> >>
> >> Fix by enabling sysemu (have_system) when virtiofsd is built.
> >>
> >> Reported-by: Mahmoud Mandour <ma.mandourr@gmail.com>
> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> >> ---
> >>  meson.build | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/meson.build b/meson.build
> >> index c6f4b0cf5e8..f858935ad95 100644
> >> --- a/meson.build
> >> +++ b/meson.build
> >> @@ -51,6 +51,8 @@
> >>    have_system = have_system or target.endswith('-softmmu')
> >>  endforeach
> >>  have_tools = 'CONFIG_TOOLS' in config_host
> >> +# virtiofsd depends on sysemu
> >> +have_system = have_system or not get_option('virtiofsd').disabled()
> > 
> > I don't think we should satisfy virtiofsd dependencies transiently by
> > depending on system emulation targets.
> > 
> > It's my understanding (and I'm happy to be corrected on this) that the
> > virtiofsd binary is orthogonal to system emulation tools. Consider a
> > situation in which someone wants to develop virtiofsd but doesn't want
> > to wait for the rest of QEMU to build and instead use their own
> > qemu-system-x86_64 installed by their distro.
> 
> This is what I understood in your previous thread with Mahmoud.
> 
> Peter questioned this orthogonality in v1, asking why virtiofsd is
> in the QEMU repository then...

People were insisting that there was an implementation in when accepting
the qemu side patches.

Dave


> > Connor
> > 
> >>  have_block = have_system or have_tools
> >>  
> >>  python = import('python').find_installation()
> >>
> > 
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK