Re: [PATCH v8 28/34] iotests: move 222 to tests/image-fleecing

[Hanna Reitz]

On 01.09.21 14:47, Vladimir Sementsov-Ogievskiy wrote:
> 01.09.2021 15:37, Hanna Reitz wrote:
> > On 24.08.21 10:38, Vladimir Sementsov-Ogievskiy wrote:
> > > Give a good name to test file.
> > >
> > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > > Reviewed-by: Max Reitz <mreitz@redhat.com>
> > > ---
> > >   tests/qemu-iotests/{222 => tests/image-fleecing} | 0
> > >   tests/qemu-iotests/{222.out => tests/image-fleecing.out} | 0
> > >   2 files changed, 0 insertions(+), 0 deletions(-)
> > >   rename tests/qemu-iotests/{222 => tests/image-fleecing} (100%)
> > >   rename tests/qemu-iotests/{222.out => tests/image-fleecing.out} 
> > > (100%)
> > >
> > > diff --git a/tests/qemu-iotests/222 
> > > b/tests/qemu-iotests/tests/image-fleecing
> > > similarity index 100%
> > > rename from tests/qemu-iotests/222
> > > rename to tests/qemu-iotests/tests/image-fleecing
> > > diff --git a/tests/qemu-iotests/222.out 
> > > b/tests/qemu-iotests/tests/image-fleecing.out
> > > similarity index 100%
> > > rename from tests/qemu-iotests/222.out
> > > rename to tests/qemu-iotests/tests/image-fleecing.out
> >
> > Good news: Including error-report.h helped with most of the CI errors.
> >
> > “Bad” news: .gitlab-ci.d/buildtest.yml has a complete ./check command 
> > line including test numbers...  Not sure if that’s a great idea, but 
> > in any case, this means that build-tcg-disabled fails because that 
> > command line includes 222.  I think the fix should be simply to 
> > replace 222 by image-fleecing.  I hope that’s alright for you?
>
> Yes, that's OK, thanks
>
> Unpredictable thing :( A reminder to always grep for file name when 
> rename it..

Yeah, but in this case...  Grepping for three-digit-numbers is just a 
pain.  (And grepping for “check” is not much better.  “./check” works 
reasonably well, but if someone invokes it differently somewhere, I will 
have missed it.)

Hanna