Re: [PATCH v8 28/34] iotests: move 222 to tests/image-fleecing

[Daniel P . Berrangé]

On Wed, Sep 01, 2021 at 02:37:52PM +0200, Hanna Reitz wrote:
> On 24.08.21 10:38, Vladimir Sementsov-Ogievskiy wrote:
> > Give a good name to test file.
> > 
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > Reviewed-by: Max Reitz <mreitz@redhat.com>
> > ---
> >   tests/qemu-iotests/{222 => tests/image-fleecing}         | 0
> >   tests/qemu-iotests/{222.out => tests/image-fleecing.out} | 0
> >   2 files changed, 0 insertions(+), 0 deletions(-)
> >   rename tests/qemu-iotests/{222 => tests/image-fleecing} (100%)
> >   rename tests/qemu-iotests/{222.out => tests/image-fleecing.out} (100%)
> > 
> > diff --git a/tests/qemu-iotests/222 
> > b/tests/qemu-iotests/tests/image-fleecing
> > similarity index 100%
> > rename from tests/qemu-iotests/222
> > rename to tests/qemu-iotests/tests/image-fleecing
> > diff --git a/tests/qemu-iotests/222.out 
> > b/tests/qemu-iotests/tests/image-fleecing.out
> > similarity index 100%
> > rename from tests/qemu-iotests/222.out
> > rename to tests/qemu-iotests/tests/image-fleecing.out
> 
> Good news: Including error-report.h helped with most of the CI errors.
> 
> “Bad” news: .gitlab-ci.d/buildtest.yml has a complete ./check command line
> including test numbers...  Not sure if that’s a great idea, but in any case,
> this means that build-tcg-disabled fails because that command line includes
> 222.  I think the fix should be simply to replace 222 by image-fleecing.  I
> hope that’s alright for you?

Yeah, I don't really like that we have a set of test numbers in the
gitlab CI config file.

We have a 'group' concept for IO tests that works perfectly well.

If one of the existing groups doesn't work, then we should create
a new "ci" group, so users running 'check' directly can accurately
replicate the CI env without typiing out a set of test numbers.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|