[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/8] ppc/pnv: Add a comment on the "primary-topology-index" p
From: |
David Gibson |
Subject: |
Re: [PATCH 3/8] ppc/pnv: Add a comment on the "primary-topology-index" property |
Date: |
Thu, 2 Sep 2021 11:36:04 +1000 |
On Wed, Sep 01, 2021 at 11:41:48AM +0200, Cédric Le Goater wrote:
> On P10, the chip id is calculated from the "Primary topology table
> index". See skiboot commits for more information [1].
>
> This information is extracted from the hdata on real systems which
> QEMU needs to emulate. Add this property for all machines even if it
> is only used on POWER10.
>
> [1] https://github.com/open-power/skiboot/commit/2ce3f083f399
> https://github.com/open-power/skiboot/commit/a2d4d7f9e14a
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Applied to ppc-for-6.2, thanks.
> ---
> hw/ppc/pnv_xscom.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/ppc/pnv_xscom.c b/hw/ppc/pnv_xscom.c
> index faa488e3117a..9ce018dbc279 100644
> --- a/hw/ppc/pnv_xscom.c
> +++ b/hw/ppc/pnv_xscom.c
> @@ -284,6 +284,10 @@ int pnv_dt_xscom(PnvChip *chip, void *fdt, int
> root_offset,
> _FDT(xscom_offset);
> g_free(name);
> _FDT((fdt_setprop_cell(fdt, xscom_offset, "ibm,chip-id",
> chip->chip_id)));
> + /*
> + * On P10, the xscom bus id has been deprecated and the chip id is
> + * calculated from the "Primary topology table index". See skiboot.
> + */
> _FDT((fdt_setprop_cell(fdt, xscom_offset, "ibm,primary-topology-index",
> chip->chip_id)));
> _FDT((fdt_setprop_cell(fdt, xscom_offset, "#address-cells", 1)));
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH 0/8] ppc: cleanups, Cédric Le Goater, 2021/09/01
- [PATCH 3/8] ppc/pnv: Add a comment on the "primary-topology-index" property, Cédric Le Goater, 2021/09/01
- Re: [PATCH 3/8] ppc/pnv: Add a comment on the "primary-topology-index" property,
David Gibson <=
- [PATCH 2/8] ppc/spapr: Add a POWER10 DD2 CPU, Cédric Le Goater, 2021/09/01
- [PATCH 1/8] docs/system: ppc: Update the URL for OpenPOWER firmware images, Cédric Le Goater, 2021/09/01
- [PATCH 4/8] ppc/pnv: Remove useless variable, Cédric Le Goater, 2021/09/01
- [PATCH 5/8] ppc/pnv: Add an assert when calculating the RAM distribution on chips, Cédric Le Goater, 2021/09/01