[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/5] hw/virtio: Document virtio_queue_packed_empty_rcu is call
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 1/5] hw/virtio: Document virtio_queue_packed_empty_rcu is called within RCU |
Date: |
Thu, 2 Sep 2021 18:50:35 +0200 |
While virtio_queue_packed_empty_rcu() uses the '_rcu' suffix,
it is not obvious it is called within rcu_read_lock(). All other
functions from this file called with the RCU locked have a comment
describing it. Document this one similarly for consistency.
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/virtio/virtio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 874377f37a7..a5214bca612 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -634,6 +634,7 @@ static int virtio_queue_split_empty(VirtQueue *vq)
return empty;
}
+/* Called within rcu_read_lock(). */
static int virtio_queue_packed_empty_rcu(VirtQueue *vq)
{
struct VRingPackedDesc desc;
--
2.31.1
- [PATCH v2 0/5] hw/virtio: Minor housekeeping patches, Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v2 1/5] hw/virtio: Document virtio_queue_packed_empty_rcu is called within RCU,
Philippe Mathieu-Daudé <=
- [PATCH v2 2/5] hw/virtio: Comment virtqueue_flush() must be called with RCU read lock, Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v2 3/5] hw/virtio: Remove NULL check in virtio_free_region_cache(), Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v2 4/5] hw/virtio: Acquire RCU read lock in virtqueue_packed_drop_all(), Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v2 5/5] hw/virtio: Have virtqueue_get_avail_bytes() pass caches arg to callees, Philippe Mathieu-Daudé, 2021/09/02
- Re: [PATCH v2 0/5] hw/virtio: Minor housekeeping patches, Michael S. Tsirkin, 2021/09/05