[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/5] hw/virtio: Comment virtqueue_flush() must be called with
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 2/5] hw/virtio: Comment virtqueue_flush() must be called with RCU read lock |
Date: |
Thu, 2 Sep 2021 18:50:36 +0200 |
Reported-by: Stefano Garzarella <sgarzare@redhat.com>
Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/hw/virtio/virtio.h | 7 +++++++
hw/virtio/virtio.c | 1 +
2 files changed, 8 insertions(+)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index 8bab9cfb750..c1c5f6e53c8 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -186,6 +186,13 @@ void virtio_delete_queue(VirtQueue *vq);
void virtqueue_push(VirtQueue *vq, const VirtQueueElement *elem,
unsigned int len);
+/**
+ * virtqueue_flush:
+ * @vq: The #VirtQueue
+ * @count: Number of elements to flush
+ *
+ * Must be called within RCU critical section.
+ */
void virtqueue_flush(VirtQueue *vq, unsigned int count);
void virtqueue_detach_element(VirtQueue *vq, const VirtQueueElement *elem,
unsigned int len);
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index a5214bca612..b37344bb5e1 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -898,6 +898,7 @@ static void virtqueue_packed_flush(VirtQueue *vq, unsigned
int count)
}
}
+/* Called within rcu_read_lock(). */
void virtqueue_flush(VirtQueue *vq, unsigned int count)
{
if (virtio_device_disabled(vq->vdev)) {
--
2.31.1
- [PATCH v2 0/5] hw/virtio: Minor housekeeping patches, Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v2 1/5] hw/virtio: Document virtio_queue_packed_empty_rcu is called within RCU, Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v2 2/5] hw/virtio: Comment virtqueue_flush() must be called with RCU read lock,
Philippe Mathieu-Daudé <=
- [PATCH v2 3/5] hw/virtio: Remove NULL check in virtio_free_region_cache(), Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v2 4/5] hw/virtio: Acquire RCU read lock in virtqueue_packed_drop_all(), Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v2 5/5] hw/virtio: Have virtqueue_get_avail_bytes() pass caches arg to callees, Philippe Mathieu-Daudé, 2021/09/02
- Re: [PATCH v2 0/5] hw/virtio: Minor housekeeping patches, Michael S. Tsirkin, 2021/09/05