[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 5/9] nbd/client-connection: improve error message of cance
From: |
Eric Blake |
Subject: |
Re: [PATCH v3 5/9] nbd/client-connection: improve error message of cancelled attempt |
Date: |
Tue, 7 Sep 2021 15:45:57 -0500 |
User-agent: |
NeoMutt/20210205-739-420e15 |
On Mon, Sep 06, 2021 at 10:06:50PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> nbd/client-connection.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/nbd/client-connection.c b/nbd/client-connection.c
> index 722998c985..2bda42641d 100644
> --- a/nbd/client-connection.c
> +++ b/nbd/client-connection.c
> @@ -351,8 +351,15 @@ nbd_co_establish_connection(NBDClientConnection *conn,
> NBDExportInfo *info,
> if (conn->err) {
> error_propagate(errp, error_copy(conn->err));
> } else {
> - error_setg(errp,
> - "Connection attempt cancelled by other
> operation");
> + /*
> + * The only possible case here is cancelling by open_timer
> + * during nbd_open(). So, the error message is for that case.
> + * If we have more use cases, we can refactor
> + * nbd_co_establish_connection_cancel() to take an additional
> + * parameter cancel_reason, that would be passed than to the
> + * caller of cancelled nbd_co_establish_connection().
> + */
> + error_setg(errp, "Connection attempt cancelled by timeout");
> }
>
> return NULL;
> --
> 2.29.2
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [PATCH v3 2/9] qapi: make blockdev-add a coroutine command, (continued)
[PATCH v3 3/9] nbd: allow reconnect on open, with corresponding new options, Vladimir Sementsov-Ogievskiy, 2021/09/06
[PATCH v3 9/9] iotests: add nbd-reconnect-on-open test, Vladimir Sementsov-Ogievskiy, 2021/09/06
[PATCH v3 5/9] nbd/client-connection: improve error message of cancelled attempt, Vladimir Sementsov-Ogievskiy, 2021/09/06
- Re: [PATCH v3 5/9] nbd/client-connection: improve error message of cancelled attempt,
Eric Blake <=
[PATCH v3 4/9] nbd/client-connection: nbd_co_establish_connection(): return real error, Vladimir Sementsov-Ogievskiy, 2021/09/06
[PATCH v3 8/9] iotests.py: add qemu_io_popen(), Vladimir Sementsov-Ogievskiy, 2021/09/06
[PATCH v3 7/9] iotests.py: add and use qemu_io_wrap_args(), Vladimir Sementsov-Ogievskiy, 2021/09/06
[PATCH v3 6/9] iotests.py: add qemu_tool_popen(), Vladimir Sementsov-Ogievskiy, 2021/09/06