qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 9/9] iotests: add nbd-reconnect-on-open test


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v3 9/9] iotests: add nbd-reconnect-on-open test
Date: Wed, 8 Sep 2021 10:55:22 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

07.09.2021 23:51, Eric Blake wrote:
+def check_fail_to_connect(open_timeout):
+    log(f'Check fail to connect with {open_timeout} seconds of timeout')
+
+    start_t = time.time()
+    qemu_io_log(*create_args(open_timeout))
+    delta_t = time.time() - start_t
+
+    max_delta = open_timeout + 0.2
Is this fractional delay going to bite us on heavily-loaded CI machines?


You mean that it's too small and may be racy? Hmm. But increasing it now means 
wasting extra time.. I'd adjust it when CI fail if it happens.

--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]