[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fuzz: fix unbound variable in build.sh
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] fuzz: fix unbound variable in build.sh |
|
Date: |
Wed, 8 Sep 2021 08:06:27 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 07/09/21 13:08, Alexander Bulekov wrote:
-if [ "$GITLAB_CI" != "true" ]; then
+if [ -z ${GITLAB_CI+x} ]; then
I would slightly prefer to have "${GITLAB_CI+x}", since "test" in
general doesn't like parameters that go away:
$ [ = abc ]
bash: [: =: unary operator expected
What you wrote however works, so it's okay.
Thanks,
Paolo