qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v3 13/32] rust: use vendored-sources


From: Ian Jackson
Subject: Re: [RFC v3 13/32] rust: use vendored-sources
Date: Wed, 8 Sep 2021 16:38:53 +0100

marcandre.lureau@redhat.com writes ("[RFC v3 13/32] rust: use 
vendored-sources"):
> Most likely, QEMU will want tighter control over the sources, rather
> than relying on crates.io downloading, use a git submodule with all the
> dependencies. However, cargo --offline was added in 1.36.

Hi.

pm215 pointed me at this, as I have some background in Rust.
I definitely approve of having Rust in Qemu.  I don't have an opinion
about whether the sources should be vendored this way.

But, I tried to build this, and

    error: failed to select a version for the requirement `cc = "=1.0.70"`
    candidate versions found which didn't match: 1.0.69
    location searched: directory source 
`/volatile/rustcargo/Rustup/Qemu/qemu.pwt/rust/vendored` (which is replacing 
registry `crates-io`)
    required by package `nix v0.20.1`
        ... which is depended on by `qga v0.1.0 
(/volatile/rustcargo/Rustup/Qemu/qemu.pwt/qga)`
    perhaps a crate was updated and forgotten to be re-vendored?
    As a reminder, you're using offline mode (--offline) which can sometimes 
cause surprising resolution failures, if this error is too confusing you may 
wish to retry without the offline flag.

I think the most important part here is to get the general APIs,
presented to general Rust code in Qemu, right.  So I wanted to review
those via the output from rustdoc.

I tried commenting out the `replace-with` in .cargo/config.toml
but evidently the systme isn't intended to be used that way.

Ian.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]