[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 18/21] util: Suppress -Wstringop-overflow in qemu_thread_start
From: |
Paolo Bonzini |
Subject: |
[PULL 18/21] util: Suppress -Wstringop-overflow in qemu_thread_start |
Date: |
Mon, 13 Sep 2021 13:57:39 +0200 |
From: Richard Henderson <richard.henderson@linaro.org>
This seems to be either a glibc or gcc bug, but the code
appears to be fine with the warning suppressed.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210803211907.150525-1-richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
util/qemu-thread-posix.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c
index fd9d714038..6c5004220d 100644
--- a/util/qemu-thread-posix.c
+++ b/util/qemu-thread-posix.c
@@ -537,9 +537,28 @@ static void *qemu_thread_start(void *args)
QEMU_TSAN_ANNOTATE_THREAD_NAME(qemu_thread_args->name);
g_free(qemu_thread_args->name);
g_free(qemu_thread_args);
+
+ /*
+ * GCC 11 with glibc 2.17 on PowerPC reports
+ *
+ * qemu-thread-posix.c:540:5: error: ‘__sigsetjmp’ accessing 656 bytes
+ * in a region of size 528 [-Werror=stringop-overflow=]
+ * 540 | pthread_cleanup_push(qemu_thread_atexit_notify, NULL);
+ * | ^~~~~~~~~~~~~~~~~~~~
+ *
+ * which is clearly nonsense.
+ */
+#pragma GCC diagnostic push
+#ifndef __clang__
+#pragma GCC diagnostic ignored "-Wstringop-overflow"
+#endif
+
pthread_cleanup_push(qemu_thread_atexit_notify, NULL);
r = start_routine(arg);
pthread_cleanup_pop(1);
+
+#pragma GCC diagnostic pop
+
return r;
}
--
2.31.1
- [PULL 19/21] Only check CONFIG_NVMM when NEED_CPU_H is defined, (continued)
- [PULL 19/21] Only check CONFIG_NVMM when NEED_CPU_H is defined, Paolo Bonzini, 2021/09/13
- [PULL 04/21] target/i386: Moved int_ctl into CPUX86State structure, Paolo Bonzini, 2021/09/13
- [PULL 14/21] meson: look up cp and dtrace with find_program(), Paolo Bonzini, 2021/09/13
- [PULL 16/21] meson: remove dead variable, Paolo Bonzini, 2021/09/13
- [PULL 07/21] target/i386: Added changed priority check for VIRQ, Paolo Bonzini, 2021/09/13
- [PULL 05/21] target/i386: Added VGIF V_IRQ masking capability, Paolo Bonzini, 2021/09/13
- [PULL 13/21] meson.build: Do not look for VNC-related libraries if have_system is not set, Paolo Bonzini, 2021/09/13
- [PULL 17/21] fw_cfg: add etc/msr_feature_control, Paolo Bonzini, 2021/09/13
- [PULL 15/21] meson: do not use python.full_path() unnecessarily, Paolo Bonzini, 2021/09/13
- [PULL 20/21] Fix nvmm_ram_block_added() function arguments, Paolo Bonzini, 2021/09/13
- [PULL 18/21] util: Suppress -Wstringop-overflow in qemu_thread_start,
Paolo Bonzini <=
- [PULL 21/21] docs: link to archived Fedora code of conduct, Paolo Bonzini, 2021/09/13
- Re: [PULL 00/21] x86, docs, meson changes for 2021-09-13, Peter Maydell, 2021/09/13