Re: [PATCH 13/22] test-qobject-output-visitor: Wean off UserDefListUnion

[Eric Blake]

On Mon, Sep 13, 2021 at 02:39:23PM +0200, Markus Armbruster wrote:
> The test_visitor_out_list_union_FOO() use simple union
> UserDefListUnion to cover lists of builtin types.  Rewrite as
> test_visitor_out_list_struct(), using struct ArrayStruct and a lot
> less code.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  tests/unit/test-qobject-output-visitor.c | 391 ++++++-----------------
>  1 file changed, 93 insertions(+), 298 deletions(-)
>

Nice simplification.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org