[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 17/22] tests/qapi-schema: Rewrite simple union TestIfUnion to
From: |
Eric Blake |
Subject: |
Re: [PATCH 17/22] tests/qapi-schema: Rewrite simple union TestIfUnion to be flat |
Date: |
Mon, 13 Sep 2021 10:28:58 -0500 |
User-agent: |
NeoMutt/20210205-772-2b4c52 |
On Mon, Sep 13, 2021 at 02:39:27PM +0200, Markus Armbruster wrote:
> Simple unions predate flat unions. Having both complicates the QAPI
> schema language and the QAPI generator. We haven't been using simple
> unions in new code for a long time, because they are less flexible and
> somewhat awkward on the wire.
>
> To prepare for their removal, rewrite TestIfUnion to be flat.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/qapi-schema/qapi-schema-test.json | 4 +++-
> tests/qapi-schema/qapi-schema-test.out | 16 ++++++----------
> 2 files changed, 9 insertions(+), 11 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [PATCH 01/22] qapi: Tidy up unusual line breaks, (continued)
[PATCH 20/22] tests/qapi-schema: Purge simple unions from tests, Markus Armbruster, 2021/09/13
[PATCH 03/22] qapi: Convert simple union KeyValue to flat one, Markus Armbruster, 2021/09/13
[PATCH 07/22] qapi: Convert simple union ChardevBackend to flat one, Markus Armbruster, 2021/09/13
[PATCH 17/22] tests/qapi-schema: Rewrite simple union TestIfUnion to be flat, Markus Armbruster, 2021/09/13
- Re: [PATCH 17/22] tests/qapi-schema: Rewrite simple union TestIfUnion to be flat,
Eric Blake <=
[PATCH 09/22] qapi: Convert simple union ImageInfoSpecific to flat one, Markus Armbruster, 2021/09/13
[PATCH 19/22] tests/qapi-schema: Drop simple union __org.qemu_x-Union1, Markus Armbruster, 2021/09/13
[PATCH 13/22] test-qobject-output-visitor: Wean off UserDefListUnion, Markus Armbruster, 2021/09/13
[PATCH 08/22] qapi: Convert simple union SocketAddressLegacy to flat one, Markus Armbruster, 2021/09/13
[PATCH 18/22] test-clone-visitor: Wean off __org.qemu_x-Union1, Markus Armbruster, 2021/09/13