[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 4/7] accel/tcg: Move clear_helper_retaddr to cpu loop
From: |
Richard Henderson |
Subject: |
[RFC PATCH 4/7] accel/tcg: Move clear_helper_retaddr to cpu loop |
Date: |
Mon, 13 Sep 2021 15:05:49 -0700 |
Currently there are only two places that require we reset this
value before exiting to the main loop, but that will change.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/cpu-exec.c | 3 ++-
accel/tcg/user-exec.c | 2 --
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 75dbc1e4e3..13c4436e5d 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -451,6 +451,7 @@ void cpu_exec_step_atomic(CPUState *cpu)
* memory.
*/
#ifndef CONFIG_SOFTMMU
+ clear_helper_retaddr();
tcg_debug_assert(!have_mmap_lock());
#endif
if (qemu_mutex_iothread_locked()) {
@@ -460,7 +461,6 @@ void cpu_exec_step_atomic(CPUState *cpu)
qemu_plugin_disable_mem_helpers(cpu);
}
-
/*
* As we start the exclusive region before codegen we must still
* be in the region if we longjump out of either the codegen or
@@ -903,6 +903,7 @@ int cpu_exec(CPUState *cpu)
#endif
#ifndef CONFIG_SOFTMMU
+ clear_helper_retaddr();
tcg_debug_assert(!have_mmap_lock());
#endif
if (qemu_mutex_iothread_locked()) {
diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c
index daef34a426..83351db719 100644
--- a/accel/tcg/user-exec.c
+++ b/accel/tcg/user-exec.c
@@ -157,7 +157,6 @@ bool handle_sigsegv_accerr_write(CPUState *cpu, sigset_t
*old_set,
* currently executing TB was modified and must be exited
* immediately. Clear helper_retaddr for next execution.
*/
- clear_helper_retaddr();
cpu_exit_tb_from_sighandler(cpu, old_set);
/* NORETURN */
@@ -222,7 +221,6 @@ static inline int handle_cpu_signal(uintptr_t pc, siginfo_t
*info,
* an exception. Undo signal and retaddr state prior to longjmp.
*/
sigprocmask(SIG_SETMASK, old_set, NULL);
- clear_helper_retaddr();
cc = CPU_GET_CLASS(cpu);
cc->tcg_ops->tlb_fill(cpu, address, 0, access_type,
--
2.25.1
- [RFC PATCH 6/7] linux-user: Handle SIGSEGV/SIGBUS in host_to_target_siginfo_noswap, (continued)
- [RFC PATCH 6/7] linux-user: Handle SIGSEGV/SIGBUS in host_to_target_siginfo_noswap, Richard Henderson, 2021/09/13
- [RFC PATCH 2/7] accel/tcg: Split out adjust_signal_pc, Richard Henderson, 2021/09/13
- [RFC PATCH 3/7] accel/tcg: Split out handle_sigsegv_accerr_write, Richard Henderson, 2021/09/13
- [RFC PATCH 1/7] include/exec: Move cpu_signal_handler declaration, Richard Henderson, 2021/09/13
- [RFC PATCH 4/7] accel/tcg: Move clear_helper_retaddr to cpu loop,
Richard Henderson <=
- [RFC PATCH 5/7] accel/tcg: Fold cpu_exit_tb_from_sighandler into caller, Richard Henderson, 2021/09/13
- [RFC PATCH 7/7] linux-user: Reorg cpu_signal_handler, Richard Henderson, 2021/09/13
- Re: [RFC PATCH 0/7] linux-user: Streamline handling of SIGSEGV/SIGBUS, Richard Henderson, 2021/09/13