Re: [RFC PATCH 2/7] accel/tcg: Split out adjust_signal_pc

[Philippe Mathieu-Daudé]

On 9/14/21 12:05 AM, Richard Henderson wrote:
> Split out a function to adjust the raw signal pc into a
> value that could be passed to cpu_restore_state.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  include/exec/exec-all.h |  8 +++++++
>  accel/tcg/user-exec.c   | 50 ++++++++++++++++++++++++++---------------
>  2 files changed, 40 insertions(+), 18 deletions(-)

> -/* 'pc' is the host PC at which the exception was raised. 'address' is
> -   the effective address of the memory exception. 'is_write' is 1 if a
> -   write caused the exception and otherwise 0'. 'old_set' is the
> -   signal set which should be restored */
> -static inline int handle_cpu_signal(uintptr_t pc, siginfo_t *info,
> -                                    int is_write, sigset_t *old_set)

> +/* 'pc' is the host PC at which the exception was raised. 'address' is
> +   the effective address of the memory exception. 'is_write' is 1 if a
> +   write caused the exception and otherwise 0'. 'old_set' is the
> +   signal set which should be restored */
Pre-existing extra "'" in "otherwise 0."

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>