Re: [qemu-web PATCH] Gemfile: Add webrick bundle dependency

[Daniel P . Berrangé]

On Tue, Sep 14, 2021 at 07:17:11AM +0200, Thomas Huth wrote:
> On 13/09/2021 20.29, Philippe Mathieu-Daudé wrote:
> > Without the webrick bundle, jekyll fails to start:
> > 
> >    $ bundle exec jekyll serve
> >    Ignoring ffi-1.11.1 because its extensions are not built. Try: gem 
> > pristine ffi --version 1.11.1
> >    Configuration file: qemu-web/_config.yml
> >                Source: qemu-web
> >           Destination: qemu-web/_site
> >     Incremental build: disabled. Enable with --incremental
> >          Generating...
> >           Jekyll Feed: Generating feed for posts
> >                        done in 0.686 seconds.
> >     Auto-regeneration: enabled for 'qemu-web'
> >                        ------------------------------------------------
> >          Jekyll 4.0.1   Please append `--trace` to the `serve` command
> >                         for any additional information or backtrace.
> >                        ------------------------------------------------
> >    
> > qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve/servlet.rb:3:in
> >  `require': cannot load such file -- webrick (LoadError)
> >            from 
> > qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve/servlet.rb:3:in
> >  `<top (required)>'
> >            from 
> > qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:179:in
> >  `require_relative'
> >            from 
> > qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:179:in
> >  `setup'
> >            from 
> > qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:100:in
> >  `process'
> >            from 
> > qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in 
> > `block in process_with_graceful_fail'
> >            from 
> > qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in 
> > `each'
> >            from 
> > qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in 
> > `process_with_graceful_fail'
> >            from 
> > qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:86:in
> >  `block (2 levels) in init_with_program'
> >            from 
> > qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in
> >  `block in execute'
> >            from 
> > qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in
> >  `each'
> >            from 
> > qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in
> >  `execute'
> >            from 
> > qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in
> >  `go'
> >            from 
> > qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary.rb:19:in 
> > `program'
> >            from 
> > qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/exe/jekyll:15:in `<top 
> > (required)>'
> > 
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> >   Gemfile | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/Gemfile b/Gemfile
> > index 6a7852e..dc35cb7 100644
> > --- a/Gemfile
> > +++ b/Gemfile
> > @@ -25,3 +25,5 @@ end
> >   # for https://github.com/sass/sassc-ruby/issues/146
> >   gem "sassc", ">= 2.2.1"
> > +
> > +gem "webrick", "~> 1.7"
> 
> Daniel, is this fixing the jekyll problem for you, too?
> 
> I'm still on ruby 2.5.9 where this does not occur yet... might be good to
> mention that this is a new problem with ruby 3.0 in the cover letter.

Yes, this is needed to fix Ruby 3.

I didn't propose it myself as I'm not sure if it in turn breaks people
with Ruby 2.x ?


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|