|
From: | Thomas Huth |
Subject: | Re: [qemu-web PATCH] Gemfile: Add webrick bundle dependency |
Date: | Thu, 16 Sep 2021 06:55:48 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
On 16/09/2021 06.24, Philippe Mathieu-Daudé wrote:
On 9/16/21 12:27 AM, Paolo Bonzini wrote:On 14/09/21 10:21, Daniel P. Berrangé wrote:Yes, this is needed to fix Ruby 3. I didn't propose it myself as I'm not sure if it in turn breaks people with Ruby 2.x ?Does it pass the GitLab CI (which uses 2.5)?Yes: https://gitlab.com/philmd/qemu-web/-/jobs/1594757246#L466 Installing webrick 1.7.0 Bundle complete! 5 Gemfile dependencies, 32 gems now installed.
The patch is also not breaking anything for me here (with Ruby 2.5.9). Pushed now.
Thanks, Thomas
[Prev in Thread] | Current Thread | [Next in Thread] |