Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type

[Joel Stanley]

On Tue, 14 Sept 2021 at 11:59, Peter Delevoryas <pdel@fb.com> wrote:
>
>
> > On Sep 14, 2021, at 3:56 AM, Cédric Le Goater <clg@kaod.org> wrote:
> >
> > 
> > Hello Peter D,
> >
> >> +static void aspeed_machine_fuji_class_init(ObjectClass *oc, void *data)
> >> +{
> >> +    MachineClass *mc = MACHINE_CLASS(oc);
> >> +    AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(oc);
> >> +
> >> +    mc->desc = "Facebook Fuji BMC (Cortex-A7)";
> >> +    amc->soc_name = "ast2600-a3";
> >> +    amc->hw_strap1 = FUJI_BMC_HW_STRAP1;
> >> +    amc->hw_strap2 = FUJI_BMC_HW_STRAP2;
> >> +    amc->fmc_model = "mx66l1g45g";
> >> +    amc->spi_model = "mx66l1g45g";
> >> +    amc->num_cs = 2;
> >> +    amc->macs_mask = ASPEED_MAC3_ON;
> >> +    amc->i2c_init = fuji_bmc_i2c_init;
> >> +    amc->uart_default = ASPEED_DEV_UART1;
> >> +    mc->default_ram_size = 2 * GiB;
> >
> > Is that the default of the Fuji board ? This is causing an issue in our 
> > tests :
> >
> >   qemu-system-aarch64: at most 2047 MB RAM can be simulated
> >
> > Could we lower it down to 1G ?
>
> Yikes, sorry about that. I thought it was 2G, but yeah let’s just lower it to 
> 1G. I might be completely wrong anyways.

The upstream device tree uses 2G:

https://elixir.bootlin.com/linux/v5.15-rc1/source/arch/arm/boot/dts/ast2600-facebook-netbmc-common.dtsi#L20

It's unfortunate we limit the defaults given very few (no one?) is
using this model on a machine that is 32 bit.

OTOH, modelling 1G of RAM is useful for testing, so it's no great loss.

Cheers,

Joel