Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type

[Cédric Le Goater]

On 9/16/21 15:53, Philippe Mathieu-Daudé wrote:
> On 9/16/21 2:29 PM, Cédric Le Goater wrote:
> > On 9/14/21 17:22, Richard Henderson wrote:
> > > On 9/14/21 5:26 AM, Peter Maydell wrote:
> > > > (2) RAM blocks should have a length that fits inside a
> > > >       signed 32-bit type on 32-bit hosts (at least I assume this
> > > >       is where the 2047MB limit is coming from; in theory this ought
> > > >       to be improveable but auditing the code for mishandling of
> > > >       RAMblock sizes to ensure we weren't accidentally stuffing
> > > >       their size into a signed 'long' somewhere would be kind
> > > >       of painful)
>
> > > > Even if we did fix (2) we'd need to compromise on (3)
> > > > sometimes still -- if a board has 4GB of RAM that's
> > > > not going to fit in 32 bits regardless. But we would be
> > > > able to let boards with 2GB have 2GB.
> > >
> > > I'm not opposed to deprecating 32-bit hosts...  ;-)
> >
> > Until then, I am willing to make the following compromise for the fuji  :
> >
> >      mc->default_ram_size = (HOST_LONG_BITS == 32 ? 1 : 2) * GiB;
>
> While I disagree with this approach, better to document it clearly
> like commit 25ff112a8cc ("hw/arm/mps2-tz: Add new mps3-an524 board").

OK. The patch I had prepared was a bit more explicit :

    /* On 32-bit hosts, lower RAM to 1G because of 2047 MB limit */
    mc->default_ram_size = (HOST_LONG_BITS == 32 ? 1 : 2) * GiB;

I even have a version with a warn_report() since 32-bit hosts are
not that common these days. But let's adopt the mps3-an524 board
approach.

Thanks,

C.