Re: [PATCH 1/2] iotests: Fix unspecified-encoding pylint warnings

[John Snow]

On Tue, Aug 24, 2021 at 11:47 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:

On 8/24/21 5:35 PM, Hanna Reitz wrote:
> As of recently, pylint complains when `open()` calls are missing an
> `encoding=` specified.  Everything we have should be UTF-8 (and in fact,
> everything should be UTF-8, period (exceptions apply)), so use that.
>
> Signed-off-by: Hanna Reitz <hreitz@redhat.com>
> ---
>  tests/qemu-iotests/297        | 2 +-
>  tests/qemu-iotests/iotests.py | 8 +++++---
>  2 files changed, 6 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

I don't see this upstream just yet, so ...

Reviewed-by: John Snow <jsnow@redhat.com>

I'll get around to revisiting my "run the iotest linters on Python CI" thing soon which will flush out anything else that might still be missing.

--js